Re: Review Request 59541: Fixed flakiness in MasterAllocatorTest.FrameworkExited.

2017-05-25 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59541/#review176115 --- Ship it! LGTM! - Anand Mazumdar On May 25, 2017, 6:36 p.m.,

Re: Review Request 59541: Fixed flakiness in MasterAllocatorTest.FrameworkExited.

2017-05-25 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59541/ --- (Updated May 25, 2017, 6:36 p.m.) Review request for mesos and Anand Mazumdar.

Re: Review Request 59541: Fixed flakiness in MasterAllocatorTest.FrameworkExited.

2017-05-25 Thread Neil Conway
> On May 25, 2017, 3:58 a.m., Anand Mazumdar wrote: > > src/tests/master_allocator_tests.cpp > > Lines 719-720 (patched) > > > > > > hmm, not immediately clear to me what guarrantees that this method is > > invoked

Re: Review Request 59541: Fixed flakiness in MasterAllocatorTest.FrameworkExited.

2017-05-24 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59541/#review176038 --- Looks good minus a small query.

Review Request 59541: Fixed flakiness in MasterAllocatorTest.FrameworkExited.

2017-05-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59541/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-7552