Re: Review Request 59556: Windows: Updated build documentation.

2017-05-25 Thread Andrew Schwartzmeyer
> On May 25, 2017, 9:20 p.m., Joseph Wu wrote: > > docs/windows.md > > Lines 10-13 (original), 10-11 (patched) > > > > > > These double-newlines are part of the markdown style guidelines we use > > in Mesos docs.

Re: Review Request 59556: Windows: Updated build documentation.

2017-05-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59556/#review176128 --- Ship it! I can make some of these tweaks before committing.

Re: Review Request 59556: Windows: Updated build documentation.

2017-05-25 Thread Li Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59556/#review176108 --- Ship it! Ship It! - Li Li On May 24, 2017, 11:38 p.m.,

Re: Review Request 59556: Windows: Updated build documentation.

2017-05-25 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59556/#review176085 --- Ship it! Ship It! - Jeff Coffler On May 24, 2017, 11:38

Re: Review Request 59556: Windows: Updated build documentation.

2017-05-24 Thread Andrew Schwartzmeyer
> On May 25, 2017, 12:04 a.m., Jeff Coffler wrote: > > docs/windows.md > > Lines 34 (patched) > > > > > > Do you want to mention this? > > > > I thought this was going away with your current set of patches,

Re: Review Request 59556: Windows: Updated build documentation.

2017-05-24 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59556/#review176024 --- docs/windows.md Lines 34 (patched)

Review Request 59556: Windows: Updated build documentation.

2017-05-24 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59556/ --- Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.