Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

> On July 5, 2017, 8:02 p.m., Alexander Rojas wrote: > > src/common/http.cpp > > Lines 1199-1200 (patched) > > > > > > make use of the new constructors. Yep, the new constructor patch will be merged after these co

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179693 --- src/common/http.cpp Lines 1199-1200 (patched)

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

> On July 3, 2017, 9:51 a.m., Alexander Rojas wrote: > > src/common/http.hpp > > Lines 175-229 (patched) > > > > > > What is the point of having multiple different > > `AuthorizationAcceptors`? Each have a method w

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

> On July 3, 2017, 9:51 a.m., Alexander Rojas wrote: > > I think the acceptor files do not belong in the `common/http.?pp` files. > > Perhaps create a new header called acceptors? Agree, since these Acceptors contain logic about not only HTTP request but also Authorization. It's better to move

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179491 --- src/common/http.hpp Lines 181 (patched)

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179488 --- I think the acceptor files do not belong in the `common/http.?pp`

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/ --- (Updated June 30, 2017, 11:57 p.m.) Review request for mesos, Anand Mazumdar, A

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/ --- (Updated June 30, 2017, 11:46 p.m.) Review request for mesos, Anand Mazumdar, A

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179432 --- src/master/http.cpp Lines 3758 (patched)

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179431 --- src/master/http.cpp Lines 3758-3762 (original), 3758-3767 (patche

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179430 --- src/master/http.cpp Lines 3758-3762 (original), 3758-3767 (patche

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/ --- (Updated June 30, 2017, 11:37 p.m.) Review request for mesos, Anand Mazumdar, A

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179429 --- Also note: we need to follow up these patches with updates to the

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/ --- (Updated June 30, 2017, 11:26 p.m.) Review request for mesos, Anand Mazumdar, A

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179428 --- src/tests/master_tests.cpp Lines 3510-3543 (patched)

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/ --- (Updated June 30, 2017, 1:37 a.m.) Review request for mesos, Anand Mazumdar, Al

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/ --- (Updated June 29, 2017, 7:55 p.m.) Review request for mesos, Anand Mazumdar, Al

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179295 --- Fix it, then Ship it! src/common/http.hpp Line 218 (original),

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

> On June 29, 2017, 1:12 a.m., Vinod Kone wrote: > > src/tests/master_tests.cpp > > Lines 3510 (patched) > > > > > > is the order not determinisitc in our tests? It's not deterministic, since tasks are stored in ha

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/ --- (Updated June 29, 2017, 6:09 p.m.) Review request for mesos, Anand Mazumdar, Al

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179215 --- src/master/http.cpp Line 3840 (original), 3845 (patched)

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179212 --- Fix it, then Ship it! src/common/http.hpp Lines 218 (patched)

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/ --- (Updated June 29, 2017, 12:47 a.m.) Review request for mesos, Anand Mazumdar, A

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

> On June 28, 2017, 11:31 p.m., Greg Mann wrote: > > src/tests/master_tests.cpp > > Lines 3545-3547 (patched) > > > > > > We want to assert that both of these tasks are there. Should do > > > > ``` > >

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/ --- (Updated June 29, 2017, 12:39 a.m.) Review request for mesos, Anand Mazumdar, A

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179195 --- src/common/http.hpp Lines 165 (patched)

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179192 --- Bad patch! Reviews applied: [60107] Failed command: python suppo

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/ --- (Updated June 28, 2017, 10:05 p.m.) Review request for mesos, Anand Mazumdar, A

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179184 --- src/common/http.hpp Lines 40-42 (patched)

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/ --- (Updated June 28, 2017, 9:38 p.m.) Review request for mesos, Anand Mazumdar, Al