Re: Review Request 60139: Avoided needless copy of `Owned` in libprocess.

2017-06-16 Thread Benjamin Bannier
> On June 16, 2017, 1:25 p.m., Benjamin Bannier wrote: > > I do not agree with this change. > > > > An `Owned` cannot be copied semantically. If we pass an `Owned` at all, it > > should be by value, not by reference, so potential copies happen on > > interface boundaries and we do not need to

Re: Review Request 60139: Avoided needless copy of `Owned` in libprocess.

2017-06-16 Thread Neil Conway
> On June 16, 2017, 11:25 a.m., Benjamin Bannier wrote: > > I do not agree with this change. > > > > An `Owned` cannot be copied semantically. If we pass an `Owned` at all, it > > should be by value, not by reference, so potential copies happen on > > interface boundaries and we do not need to

Re: Review Request 60139: Avoided needless copy of `Owned` in libprocess.

2017-06-16 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60139/#review178098 --- I do not agree with this change. An `Owned` cannot be copied sema

Re: Review Request 60139: Avoided needless copy of `Owned` in libprocess.

2017-06-15 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60139/#review178084 --- Ship it! Ship It! - Alexander Rojas On June 16, 2017, 1:16 a

Review Request 60139: Avoided needless copy of `Owned` in libprocess.

2017-06-15 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60139/ --- Review request for mesos and Alexander Rojas. Repository: mesos Description -