Re: Review Request 60495: Added network ports isolator listen socket utilities.

2017-09-19 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60495/#review185769 --- Ship it! Ship It! - Qian Zhang On Sept. 20, 2017, 12:29

Re: Review Request 60495: Added network ports isolator listen socket utilities.

2017-09-19 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60495/ --- (Updated Sept. 19, 2017, 4:29 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60495: Added network ports isolator listen socket utilities.

2017-09-19 Thread James Peach
> On Sept. 19, 2017, 2:18 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Line 112 (original), 112-117 (patched) > > > > > > Can we change this to `while ((entry =

Re: Review Request 60495: Added network ports isolator listen socket utilities.

2017-09-18 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60495/#review185635 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Line

Re: Review Request 60495: Added network ports isolator listen socket utilities.

2017-09-18 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60495/ --- (Updated Sept. 19, 2017, 12:19 a.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60495: Added network ports isolator listen socket utilities.

2017-09-12 Thread Qian Zhang
> On Sept. 8, 2017, 3:43 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Line 112 (original), 112 (patched) > > > > > > Why do we need a `for` loop like this? I think

Re: Review Request 60495: Added network ports isolator listen socket utilities.

2017-09-11 Thread James Peach
> On Sept. 8, 2017, 7:43 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Line 112 (original), 112 (patched) > > > > > > Why do we need a `for` loop like this? I think

Re: Review Request 60495: Added network ports isolator listen socket utilities.

2017-09-08 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60495/#review184953 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Line

Re: Review Request 60495: Added network ports isolator listen socket utilities.

2017-09-07 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60495/ --- (Updated Sept. 7, 2017, 9:50 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60495: Added network ports isolator listen socket utilities.

2017-09-04 Thread Qian Zhang
> On Aug. 8, 2017, 11:31 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 201 (patched) > > > > > > We should call `os::realpath()` to expand the symbol link. > >

Re: Review Request 60495: Added network ports isolator listen socket utilities.

2017-09-04 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60495/#review184508 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Lines

Re: Review Request 60495: Added network ports isolator listen socket utilities.

2017-09-04 Thread James Peach
> On Aug. 8, 2017, 3:31 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 201 (patched) > > > > > > We should call `os::realpath()` to expand the symbol link. > > James

Re: Review Request 60495: Added network ports isolator listen socket utilities.

2017-09-04 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60495/#review184478 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Lines

Re: Review Request 60495: Added network ports isolator listen socket utilities.

2017-09-04 Thread Qian Zhang
> On Aug. 8, 2017, 11:31 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 201 (patched) > > > > > > We should call `os::realpath()` to expand the symbol link. > >

Re: Review Request 60495: Added network ports isolator listen socket utilities.

2017-08-14 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60495/ --- (Updated Aug. 14, 2017, 11:40 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60495: Added network ports isolator listen socket utilities.

2017-08-11 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60495/#review182665 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Lines

Re: Review Request 60495: Added network ports isolator listen socket utilities.

2017-08-09 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60495/ --- (Updated Aug. 9, 2017, 8:19 p.m.) Review request for mesos, Qian Zhang and