Re: Review Request 60621: Add new stout capability: os::copyfile.

2017-10-07 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60621/#review187352 --- Summary and description need to follow Mesos standards

Re: Review Request 60621: Add new stout capability: os::copyfile.

2017-10-07 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60621/#review187346 --- The commit message needs to be in the past tense, and generally

Re: Review Request 60621: Add new stout capability: os::copyfile.

2017-10-05 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60621/ --- (Updated Oct. 6, 2017, 4:03 a.m.) Review request for mesos, Andrew

Re: Review Request 60621: Add new stout capability: os::copyfile.

2017-08-24 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60621/ --- (Updated Aug. 24, 2017, 10:39 p.m.) Review request for mesos, Andrew

Re: Review Request 60621: Add new stout capability: os::copyfile.

2017-08-24 Thread Jeff Coffler
> On Aug. 16, 2017, 12:20 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/posix/copyfile.hpp > > Lines 26 (patched) > > > > > > Oops, can't include a namespace in a header. I removed this and resolved

Re: Review Request 60621: Add new stout capability: os::copyfile.

2017-08-23 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60621/#review183631 --- 3rdparty/stout/include/stout/os/posix/copyfile.hpp Lines 26