Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

2017-12-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/#review193293 --- Ship it! Ship It! - Andrew Schwartzmeyer On Dec. 7, 2017,

Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

2017-12-07 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/ --- (Updated Dec. 8, 2017, 2:43 a.m.) Review request for mesos, Andrew

Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

2017-11-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/#review191204 --- Ship it! Ship It! - Michael Park On Nov. 6, 2017, 10:09

Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

2017-10-19 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/ --- (Updated Oct. 19, 2017, 9:33 p.m.) Review request for mesos, Andrew

Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

2017-10-19 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/ --- (Updated Oct. 19, 2017, 6:17 p.m.) Review request for mesos, Andrew

Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

2017-10-17 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/#review188417 --- Ship it! Ship It! - Andrew Schwartzmeyer On Oct. 16, 2017,

Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

2017-10-16 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/ --- (Updated Oct. 17, 2017, 1:18 a.m.) Review request for mesos, Andrew

Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

2017-10-13 Thread Andrew Schwartzmeyer
> On Oct. 7, 2017, 8:37 p.m., Andrew Schwartzmeyer wrote: > > Same comment for style on summary as before, also missing description. Also > > URI is inconsistently capitalized ;) This still needs to be addressed. - Andrew --- This is

Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

2017-10-12 Thread Jeff Coffler
On Oct. 8, 2017, 3:37 a.m., Jeff Coffler wrote: > > These changes in spirit are fine, but I don't like how the URI conversion > > has to be done at all. It should be as simple as `uri::from_path(input)`. That's exactly what I ultimately did. - Jeff

Re: Review Request 60623: Converted "file://" URI handling to use new uri function.

2017-10-11 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/ --- (Updated Oct. 11, 2017, 11:31 p.m.) Review request for mesos, Andrew