Re: Review Request 61118: Building gRPC support in libprocess with CMake.

2018-04-20 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61118/#review201663 --- Ship it! Ship It! - Andrew Schwartzmeyer On April 19, 2018,

Re: Review Request 61118: Building gRPC support in libprocess with CMake.

2018-04-19 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61118/ --- (Updated April 20, 2018, 2:31 a.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 61118: Building gRPC support in libprocess with CMake.

2018-04-18 Thread Andrew Schwartzmeyer
> On April 12, 2018, 9:55 a.m., Andrew Schwartzmeyer wrote: > > 3rdparty/libprocess/src/tests/CMakeLists.txt > > Lines 91 (patched) > > > > > > I think this should instead be appended above. That is, after setting >

Re: Review Request 61118: Building gRPC support in libprocess with CMake.

2018-04-18 Thread Andrew Schwartzmeyer
> On April 12, 2018, 9:55 a.m., Andrew Schwartzmeyer wrote: > > 3rdparty/libprocess/src/tests/CMakeLists.txt > > Lines 91 (patched) > > > > > > I think this should instead be appended above. That is, after setting >

Re: Review Request 61118: Building gRPC support in libprocess with CMake.

2018-04-16 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61118/ --- (Updated April 17, 2018, 3:17 a.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 61118: Building gRPC support in libprocess with CMake.

2017-08-04 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61118/ --- (Updated Aug. 4, 2017, 11:21 p.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 61118: Building gRPC support in libprocess with CMake.

2017-08-03 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61118/ --- (Updated Aug. 4, 2017, 1:20 a.m.) Review request for mesos, Andrew Schwartzmeye