Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Nov. 7, 2017, 11 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review190335 --- Ship it! Ship It! - Greg Mann On Nov. 7, 2017, 12:25 p.m.,

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

> On Nov. 6, 2017, 6:51 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 1280-1287 (patched) > > > > > > It would be nice if we only did this when necessary - i.e., if there > > have, in fact, been

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Nov. 7, 2017, 1:25 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review190177 --- src/slave/slave.cpp Lines 1280-1287 (patched)

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Nov. 6, 2017, 1:38 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review190047 --- Fix it, then Ship it! src/slave/slave.cpp Lines 1386

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Nov. 3, 2017, 4:21 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Nov. 2, 2017, 6:47 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Nov. 2, 2017, 2:57 a.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review186984 --- Ship it! Ship It! - Jie Yu On Sept. 29, 2017, 9:14 a.m.,

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

> On Sept. 29, 2017, 5:33 a.m., Jie Yu wrote: > > src/tests/oversubscription_tests.cpp > > Lines 324-329 (original), 333-338 (patched) > > > > > > Do you need to update those tests? This particular test case

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 29, 2017, 11:14 a.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review186632 --- src/slave/slave.cpp Line 1278 (original), 1287 (patched)

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 28, 2017, 8:42 a.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 25, 2017, 9:42 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review186112 --- Fix it, then Ship it! src/slave/slave.cpp Lines 6619

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 25, 2017, 12:28 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review185932 --- See comments below. I presume you won't need to update the

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 21, 2017, 9:24 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 21, 2017, 2:59 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review185816 --- src/slave/slave.cpp Lines 1272-1285 (patched)

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

> On Sept. 19, 2017, 12:03 a.m., Jie Yu wrote: > > src/slave/slave.cpp > > Lines 6669 (patched) > > > > > > add a `break` for the first level switch? and a default? I added a `break` here. I did not add a

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 20, 2017, 4:24 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 19, 2017, 6:53 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review185583 --- src/slave/slave.cpp Lines 1524 (patched)

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 15, 2017, 3:15 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

> On Sept. 7, 2017, 1:32 a.m., Jie Yu wrote: > > src/slave/slave.hpp > > Lines 658 (patched) > > > > > > I am not sure if keeping another field just for resoruce provider > > provided resources in the agent is a

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 8, 2017, 12:38 a.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

> On Sept. 6, 2017, 11:32 p.m., Jie Yu wrote: > > src/slave/slave.hpp > > Lines 658 (patched) > > > > > > I am not sure if keeping another field just for resoruce provider > > provided resources in the agent is a

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

> On Sept. 6, 2017, 11:32 p.m., Jie Yu wrote: > > src/slave/slave.hpp > > Lines 658 (patched) > > > > > > I am not sure if keeping another field just for resoruce provider > > provided resources in the agent is a

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

> On Sept. 7, 2017, 1:32 a.m., Jie Yu wrote: > > src/slave/slave.hpp > > Lines 658 (patched) > > > > > > I am not sure if keeping another field just for resoruce provider > > provided resources in the agent is a

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 7, 2017, 5:13 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review184751 --- src/slave/slave.hpp Lines 658 (patched)

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 6, 2017, 4:52 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Sept. 6, 2017, 2 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Aug. 1, 2017, 7:42 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

> On July 29, 2017, 12:20 a.m., Jie Yu wrote: > > src/slave/slave.cpp > > Lines 6496 (patched) > > > > > > I think we can still process `UPDATE_TOTAL_RESOURCES` message in > > DISCONNECTED state by updating

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated July 31, 2017, 5:08 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review181736 --- src/slave/slave.cpp Lines 833 (patched)

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review181574 --- Patch looks great! Reviews applied: [61179, 61180, 61181, 61182,

Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos