Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review192185 --- Ship it! Committing with some small tweaks below and for the

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 29, 2017, 12:59 a.m.) Review request for mesos, James Peach,

Re: Review Request 61473: Do not kill non partition aware tasks.

> On Nov. 27, 2017, 4:25 p.m., Ilya Pronin wrote: > > src/master/http.cpp > > Lines 343-345 (patched) > > > > > > I may be ignorant of the discussion behind this, but since we don't > > treat these tasks as

Re: Review Request 61473: Do not kill non partition aware tasks.

> On Nov. 28, 2017, 12:46 a.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Line 9370 (original), 9322 (patched) > > > > > > I have the similar feeling as Ilya, without context it's hard to > > understand

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 28, 2017, 5:28 p.m.) Review request for mesos, James Peach,

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review191976 --- Almost there! include/mesos/mesos.proto Lines 344-346

Re: Review Request 61473: Do not kill non partition aware tasks.

> On Nov. 27, 2017, 4:25 p.m., Ilya Pronin wrote: > > src/master/master.cpp > > Line 9370 (original), 9322 (patched) > > > > > > I would suggest moving this closer to `newTaskState` selection logic > > for

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 28, 2017, 12:56 a.m.) Review request for mesos, James Peach,

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review191674 --- The approach looks good to me. src/master/http.cpp Line 320

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 27, 2017, 10:08 p.m.) Review request for mesos, James Peach,

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 27, 2017, 10:05 p.m.) Review request for mesos, James Peach,

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review191409 --- FAIL: Some Mesos tests failed. Reviews applied: `['61473']`

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 17, 2017, 10:35 p.m.) Review request for mesos, James Peach,

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 17, 2017, 9:27 p.m.) Review request for mesos, James Peach,

Re: Review Request 61473: Do not kill non partition aware tasks.

> On Sept. 29, 2017, 6:19 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Lines 7169-7173 (patched) > > > > > > You have created this `newUpdate` but are not immediately using it, and > > I have to pay

Re: Review Request 61473: Do not kill non partition aware tasks.

> On Sept. 29, 2017, 6:19 p.m., Jiang Yan Xu wrote: > > src/master/master.hpp > > Lines 2475-2477 (patched) > > > > > > Because this method takes a pointer, this mutation could affect future > > uses of it. Even

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 17, 2017, 7:26 p.m.) Review request for mesos, James Peach,

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 17, 2017, 7:11 p.m.) Review request for mesos, James Peach,

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 16, 2017, 8:04 p.m.) Review request for mesos, James Peach,

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 16, 2017, 7:43 p.m.) Review request for mesos, James Peach,

Re: Review Request 61473: Do not kill non partition aware tasks.

> On Sept. 28, 2017, 9:32 p.m., James Peach wrote: > > src/master/master.cpp > > Lines 9476 (patched) > > > > > > This doesn't seem right to me. Even if the framework is not > > partition-aware, the master is

Re: Review Request 61473: Do not kill non partition aware tasks.

> On Sept. 29, 2017, 6:19 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Lines 7171-7172 (patched) > > > > > > This could be shortened to one line. > > > > ``` > >

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review191160 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 16, 2017, 7:20 a.m.) Review request for mesos, James Peach,

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 16, 2017, 5:43 a.m.) Review request for mesos, James Peach,

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 16, 2017, 5:24 a.m.) Review request for mesos, James Peach,

Re: Review Request 61473: Do not kill non partition aware tasks.

> On Oct. 26, 2017, 8:23 a.m., Jiang Yan Xu wrote: > > src/master/master.hpp > > Lines 2591 (patched) > > > > > > You made a redundant copy here but I understand this line may go away > > anyways. :) That's

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review188966 --- src/master/http.cpp Line 317 (original), 317 (patched)

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review188131 --- Bad patch! Reviews applied: [61473] Failed command: python

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review188115 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 61473: Do not kill non partition aware tasks.

> On Sept. 30, 2017, 12:37 a.m., Jiang Yan Xu wrote: > > As I commented on the JIRA, we should probably bring the work for > > MESOS-6406 into this JIRA because this JIRA wouldn't be complete without > > it. It certainly should be a different patch though. > > > > For this patch we should

Re: Review Request 61473: Do not kill non partition aware tasks.

> On Sept. 29, 2017, 6:19 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Lines 7188-7190 (original), 7144-7146 (patched) > > > > > > Our handling of `TASK_UNREACHABLE` vs. `TASK_LOST` here is a little > >

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Oct. 16, 2017, 8:59 a.m.) Review request for mesos, James Peach,

Re: Review Request 61473: Do not kill non partition aware tasks.

> On Sept. 28, 2017, 9:32 p.m., James Peach wrote: > > src/master/master.cpp > > Line 6552 (original) > > > > > > `protobuf::isTerminalState` still defines `TASK_LOST` as a terminal > > state. However we are now

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review186737 --- As I commented on the JIRA, we should probably bring the work for

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review186615 --- src/master/http.cpp Lines 324 (patched)

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review186580 --- src/master/master.hpp Line 849 (original), 849 (patched)

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review186082 --- Bad patch! Reviews applied: [61473] Failed command: python

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review185268 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 61473: Do not kill non partition aware tasks.

> On Aug. 30, 2017, 1:05 a.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Lines 8948-8950 (patched) > > > > > > If the framework is not partition aware, the `update` will already have > > a `TASK_LOST`

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Sept. 11, 2017, 9:23 p.m.) Review request for mesos, Vinod Kone and

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review184107 --- Good progress! Haven't looked at tests yet. Let's address these

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review184009 --- Failed to apply patch! Reviews applied: [61473] Logs available

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review184007 --- Bad patch! Reviews applied: [61473] Failed command: python

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review183958 --- Bad patch! Reviews applied: [61473] Failed command: python

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review183952 --- Failed to apply patch! Reviews applied: [61473] Logs available

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Aug. 28, 2017, 3:31 p.m.) Review request for mesos, Vinod Kone and

Re: Review Request 61473: Do not kill non partition aware tasks.

> On Aug. 10, 2017, 9 p.m., Jiang Yan Xu wrote: > > src/master/http.cpp > > Lines 342 (patched) > > > > > > One empty line above. Fixed > On Aug. 10, 2017, 9 p.m., Jiang Yan Xu wrote: > > src/master/http.cpp > >

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review183891 --- Bad patch! Reviews applied: [61473] Failed command: python

Re: Review Request 61473: Do not kill non partition aware tasks.

> On Aug. 10, 2017, 9 p.m., Jiang Yan Xu wrote: > > Some of the comments below were made before I started to feel that we are > > probably doing too many conversions to justify storing these tasks in > > TASK_UNREACHABLE. Perhaps we can just store them in > > `Framework.unreachableTasks` but

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review182686 --- Bad patch! Reviews applied: [61473] Logs available here:

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review182605 --- Some of the comments below were made before I started to feel

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Aug. 9, 2017, 4:55 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Aug. 9, 2017, 4:48 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review182310 --- We talked about 2 approaches and approach 2 seemed like a cleaner

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Aug. 7, 2017, 6:23 p.m.) Review request for mesos and Jiang Yan Xu.

Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-7215