Re: Review Request 61531: Fixed the device number proto 'major' and 'minor' to avoid MACROs.

2017-08-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61531/#review182697 --- Patch looks great! Reviews applied: [61531] Logs available

Re: Review Request 61531: Fixed the device number proto 'major' and 'minor' to avoid MACROs.

2017-08-10 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61531/#review182632 --- Ship it! Ship It! - James Peach On Aug. 9, 2017, 10:24

Re: Review Request 61531: Fixed the device number proto 'major' and 'minor' to avoid MACROs.

2017-08-09 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61531/ --- (Updated Aug. 9, 2017, 3:24 p.m.) Review request for mesos, Ilya Pronin, Jie

Re: Review Request 61531: Fixed the device number proto 'major' and 'minor' to avoid MACROs.

2017-08-09 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61531/#review182516 ---

Re: Review Request 61531: Fixed the device number proto 'major' and 'minor' to avoid MACROs.

2017-08-09 Thread Gilbert Song
> On Aug. 9, 2017, 11:07 a.m., James Peach wrote: > > We still need to switch to using the `major` and `minor` macros from > > `sys/sysmacros.h` so avoid the deprecation warning. > > [Here's](https://paste.fedoraproject.org/paste/QvCDIi9ZUeLG2MhVIDwhOA) what > > I would recommend. > > > >

Re: Review Request 61531: Fixed the device number proto 'major' and 'minor' to avoid MACROs.

2017-08-09 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61531/ --- (Updated Aug. 9, 2017, 12:05 p.m.) Review request for mesos, Ilya Pronin, Jie