Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

2017-10-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62176/#review186866 --- Ship it! LGTM. - Joseph Wu On Sept. 27, 2017, 12:19 p.m.,

Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

2017-09-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62176/#review185831 --- Patch looks great! Reviews applied: [62105, 62106, 62176]

Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

2017-09-19 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62176/#review185759 --- PASS: Mesos patch 62176 was successfully built and tested.

Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

2017-09-19 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62176/#review185749 --- Ship it! Ship It! - Andrew Schwartzmeyer On Sept. 19, 2017,

Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

2017-09-19 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62176/ --- (Updated Sept. 19, 2017, 4:58 p.m.) Review request for mesos, Andrew

Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

2017-09-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62176/#review185704 --- Patch looks great! Reviews applied: [62105, 62106, 62176]

Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

2017-09-18 Thread Andrew Schwartzmeyer
> On Sept. 8, 2017, 4:40 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Mesos tests failed to build. Please check > > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62176/logs/mesos-tests-cmake-build.log > > for any relevant errors > > > > Reviews applied: [62105, 62106, 62176]

Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

2017-09-18 Thread Andrew Schwartzmeyer
> On Sept. 18, 2017, 12:45 p.m., Andrew Schwartzmeyer wrote: > > Ship It! (But wait on required reviews; i.e. this isn't for the whole chain.) - Andrew --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

2017-09-18 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62176/#review185617 --- Ship it! Ship It! - Andrew Schwartzmeyer On Sept. 8, 2017,

Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

2017-09-08 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62176/#review185035 --- FAIL: Mesos tests failed to build. Please check

Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

2017-09-08 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62176/ --- (Updated Sept. 8, 2017, 10:35 p.m.) Review request for mesos, Andrew

Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

2017-09-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62176/#review184918 --- FAIL: Mesos tests failed to build. Please check

Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

2017-09-07 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62176/#review184908 --- src/CMakeLists.txt Lines 615-620 (original), 615-624 (patched)

Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

2017-09-07 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62176/ --- Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.