Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/ --- (Updated Nov. 29, 2017, 8:52 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/#review191857 --- Ship it! Ship It! - Jie Yu On Nov. 17, 2017, 1:53 a.m.,

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/ --- (Updated Nov. 17, 2017, 1:53 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

> On Nov. 16, 2017, 10:27 p.m., Jie Yu wrote: > > src/slave/container_daemon.cpp > > Lines 166 (patched) > > > > > > `response.status != http::Status::OK` Cannot do this. `response.status` is a string. -

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

> On Nov. 16, 2017, 10:27 p.m., Jie Yu wrote: > > src/slave/container_daemon.cpp > > Lines 50-61 (patched) > > > > > > Hum, so we assume v1 uses token based authentication? What if agent API > > uses basic authn?

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

> On Nov. 16, 2017, 10:27 p.m., Jie Yu wrote: > > src/slave/container_daemon.cpp > > Lines 157 (patched) > > > > > > i'd rename this to `launch`, and rename stop to `wait` Then what should be the name of the public

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/#review191257 --- src/slave/container_daemon.cpp Lines 50-61 (patched)

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/ --- (Updated Nov. 16, 2017, 9:27 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/#review191106 --- src/slave/container_daemon.hpp Lines 40 (patched)

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/ --- (Updated Nov. 15, 2017, 9:21 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/ --- (Updated Nov. 14, 2017, 9:41 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/#review190664 --- FAIL: Failed to apply the dependent review: 62145. Failed

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/ --- (Updated Nov. 10, 2017, 2:13 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/#review190555 --- Bad patch! Reviews applied: [63680, 63019, 63385, 63060, 63377,

Re: Review Request 63680: Added a container daemon to monitor a long-running standalone container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/#review190518 --- FAIL: Failed to apply the dependent review: 62145. Failed

Review Request 63680: Added a container daemon to monitor a long-running standalone container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63680/ --- Review request for mesos, Jie Yu and Joseph Wu. Bugs: MESOS-8183