Re: Review Request 63994: Added a new test for validation of offer operation IDs.

2018-03-19 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review199423 --- Ship it! Ship It! - Zhitao Li On March 16, 2018, 1:55 p.m.,

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

2018-03-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/ --- (Updated March 16, 2018, 1:55 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

2018-03-15 Thread Greg Mann
> On March 16, 2018, 12:23 a.m., Gaston Kleiman wrote: > > src/tests/scheduler_tests.cpp > > Lines 1239-1240 (patched) > > > > > > Do we need this? My understanding is that frameworks will get offers as > > soon

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

2018-03-15 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review199305 --- src/tests/scheduler_tests.cpp Lines 1239-1240 (patched)

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

2018-03-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/ --- (Updated March 16, 2018, 12:06 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

2018-03-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review199125 --- PASS: Mesos patch 63994 was successfully built and tested. Review

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

2018-03-13 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review199123 --- Ship it! Ship It! - Gaston Kleiman On March 13, 2018, 2:48 p

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

2018-03-13 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/ --- (Updated March 13, 2018, 9:48 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

2018-03-13 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review199119 --- src/tests/scheduler_tests.cpp Lines 1080 (patched)

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

2018-03-13 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review199116 --- Patch looks great! Reviews applied: [63991, 63992, 63994] Passed

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

2018-03-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review199097 --- PASS: Mesos patch 63994 was successfully built and tested. Review

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

2018-03-13 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/ --- (Updated March 13, 2018, 4:41 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

2018-03-13 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/ --- (Updated March 13, 2018, 4:39 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

2018-03-02 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review198581 --- Patch looks great! Reviews applied: [63991, 63992, 63994] Passed

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

2018-03-02 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review198571 --- PASS: Mesos patch 63994 was successfully built and tested. Review

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

2018-03-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/ --- (Updated March 2, 2018, 10:52 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

2018-03-02 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review198559 --- src/tests/scheduler_tests.cpp Lines 1045-1047 (patched)

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

2018-03-02 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review198526 --- Bad patch! Reviews applied: [63994, 63992, 63991, 63989, 63988]

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

2018-03-02 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review198514 --- FAIL: Failed to apply the dependent review: 63989. Failed command

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

2018-03-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/ --- (Updated March 2, 2018, 8:07 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63994: Added a new test for validation of offer operation IDs.

2017-11-21 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/#review191632 --- FAIL: Failed to apply the dependent review: 63767. Failed command

Review Request 63994: Added a new test for validation of offer operation IDs.

2017-11-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63994/ --- Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu. Bugs: M