Re: Review Request 64304: Enforced quota limit in the presence of unallocated reservations.

2017-12-11 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64304/#review193484 --- Fix it, then Ship it! Looks good! Just some comments related

Re: Review Request 64304: Enforced quota limit in the presence of unallocated reservations.

2017-12-10 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64304/ --- (Updated Dec. 10, 2017, 8:29 p.m.) Review request for mesos, Alexander

Re: Review Request 64304: Enforced quota limit in the presence of unallocated reservations.

2017-12-08 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64304/#review193288 --- Great to see this getting fixed! First pass over just the

Re: Review Request 64304: Enforced quota limit in the presence of unallocated reservations.

2017-12-08 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64304/ --- (Updated Dec. 8, 2017, 1:51 p.m.) Review request for mesos, Alexander

Re: Review Request 64304: Enforced quota limit in the presence of unallocated reservations.

2017-12-05 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64304/ --- (Updated Dec. 5, 2017, 2:42 p.m.) Review request for mesos, Alexander

Re: Review Request 64304: Enforced quota limit in the presence of unallocated reservations.

2017-12-05 Thread Meng Zhu
> On Dec. 4, 2017, 5:08 p.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 1272 (patched) > > > > > > After reading through the test, this is the dynamic reservation case > >

Re: Review Request 64304: Enforced quota limit in the presence of unallocated reservations.

2017-12-04 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64304/#review192789 --- src/master/allocator/mesos/hierarchical.cpp Line 1492

Re: Review Request 64304: Enforced quota limit in the presence of unallocated reservations.

2017-12-04 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64304/ --- (Updated Dec. 4, 2017, 3:18 p.m.) Review request for mesos, Alexander

Re: Review Request 64304: Enforced quota limit in the presence of unallocated reservations.

2017-12-04 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64304/ --- (Updated Dec. 4, 2017, 1:48 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 64304: Enforced quota limit in the presence of unallocated reservations.

2017-12-04 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64304/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-4527