Re: Review Request 64430: Only passed agent's resource version in top-level 'UpdateSlaveMessage'.

2017-12-08 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64430/#review193245 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied: `['644

Re: Review Request 64430: Only passed agent's resource version in top-level 'UpdateSlaveMessage'.

2017-12-08 Thread Benjamin Bannier
> On Dec. 8, 2017, 6:15 a.m., Jie Yu wrote: > > Let's also follow up with the change to remove `ResourcesCategory` I posted https://reviews.apache.org/r/64445/ to address this in isolation and on top of the changes here. - Benjamin ---

Re: Review Request 64430: Only passed agent's resource version in top-level 'UpdateSlaveMessage'.

2017-12-08 Thread Benjamin Bannier
> On Dec. 8, 2017, 6:15 a.m., Jie Yu wrote: > > src/master/master.cpp > > Line 7193 (original), 7193 (patched) > > > > > > Do we still need this? I removed this as part of https://reviews.apache.org/r/64424. > On

Re: Review Request 64430: Only passed agent's resource version in top-level 'UpdateSlaveMessage'.

2017-12-08 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64430/ --- (Updated Dec. 8, 2017, 12:32 p.m.) Review request for mesos, Jie Yu and Jan Sch

Re: Review Request 64430: Only passed agent's resource version in top-level UpdateSlaveMessage.

2017-12-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64430/#review193219 --- Let's also follow up with the change to remove `ResourcesCategory`

Re: Review Request 64430: Only passed agent's resource version in top-level UpdateSlaveMessage.

2017-12-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64430/#review193216 --- Fix it, then Ship it! src/master/master.cpp Line 7193 (origina

Review Request 64430: Only passed agent's resource version in top-level UpdateSlaveMessage.

2017-12-07 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64430/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-8312 https:/