Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue.

2017-12-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64686/ --- (Updated Dec. 22, 2017, 6:41 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue.

2017-12-22 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64686/#review194452 --- Ship it! Ship It! - Michael Park On Dec. 22, 2017, 5:42

Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue.

2017-12-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64686/ --- (Updated Dec. 22, 2017, 1:42 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue.

2017-12-22 Thread Alexander Rukletsov
> On Dec. 21, 2017, 8 p.m., Benjamin Bannier wrote: > > src/linux/ns.cpp > > Line 397 (original), 397-399 (patched) > > > > > > Why do we put `struct` here? This is C++ (and the `memcpy` fits on a > > single line

Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue.

2017-12-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64686/ --- (Updated Dec. 22, 2017, 1:39 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue.

2017-12-21 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64686/#review194363 --- PASS: Mesos patch 64686 was successfully built and tested.

Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue.

2017-12-21 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64686/#review194361 --- Fix it, then Ship it! Thanks for the updated patch Alex, for

Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue.

2017-12-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64686/ --- (Updated Dec. 21, 2017, 7:42 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue.

2017-12-19 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64686/#review194131 --- Ship it! Ship It! - Armand Grillet On Dec. 18, 2017, 7:06

Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue.

2017-12-18 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64686/#review194083 --- PASS: Mesos patch 64686 was successfully built and tested.

Review Request 64686: Fixed the type-punned pointer and strict aliasing issue.

2017-12-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64686/ --- Review request for mesos, Armand Grillet, Benjamin Bannier, and Michael Park.