Re: Review Request 65201: Added a global `DEFAULT_TEST_TIMEOUT` variable.

2018-02-07 Thread James Peach
> On Feb. 6, 2018, 10:54 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/include/process/gtest.hpp > > Lines 37 (patched) > > > > > > I'd suggest to move this to an extra header file, e.g., > > `process/tests/c

Re: Review Request 65201: Added a global `DEFAULT_TEST_TIMEOUT` variable.

2018-02-06 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65201/#review196876 --- Fix it, then Ship it! 3rdparty/libprocess/Makefile.am Lines 20

Re: Review Request 65201: Added a global `DEFAULT_TEST_TIMEOUT` variable.

2018-01-25 Thread James Peach
> On Jan. 22, 2018, 9:08 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/include/process/gtest.hpp > > Line 249 (original), 251 (patched) > > > > > > We don't really fully qualify the names here, but instead us

Re: Review Request 65201: Added a global `DEFAULT_TEST_TIMEOUT` variable.

2018-01-24 Thread Benjamin Bannier
> On Jan. 22, 2018, 10:08 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/include/process/gtest.hpp > > Line 249 (original), 251 (patched) > > > > > > We don't really fully qualify the names here, but instead u

Re: Review Request 65201: Added a global `DEFAULT_TEST_TIMEOUT` variable.

2018-01-23 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65201/ --- (Updated Jan. 23, 2018, 9:57 p.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 65201: Added a global `DEFAULT_TEST_TIMEOUT` variable.

2018-01-23 Thread James Peach
> On Jan. 22, 2018, 9:08 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/Makefile.am > > Lines 200 (patched) > > > > > > I don't really like adding this testing tool to `libprocess`. Could you > > introduce so

Re: Review Request 65201: Added a global `DEFAULT_TEST_TIMEOUT` variable.

2018-01-22 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65201/#review195938 --- 3rdparty/libprocess/Makefile.am Lines 200 (patched)

Review Request 65201: Added a global DEFAULT_TEST_TIMEOUT variable.

2018-01-17 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65201/ --- Review request for mesos, Benjamin Bannier and Gaston Kleiman. Bugs: MESOS-7016