Re: Review Request 65482: Fixed allocator bookkeeping of pending operations on master failover.

2018-02-05 Thread Benjamin Bannier
> On Feb. 3, 2018, 12:05 a.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 7596 (patched) > > > > > > Does this mean we will not correctly account for resources when a > > framework has performed operation

Re: Review Request 65482: Fixed allocator bookkeeping of pending operations on master failover.

2018-02-05 Thread Benjamin Bannier
> On Feb. 3, 2018, 12:06 a.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 7594-7597 (original), 7609-7612 (patched) > > > > > > Is this function now only called with resources from already-existing > > fr

Re: Review Request 65482: Fixed allocator bookkeeping of pending operations on master failover.

2018-02-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65482/#review196752 --- src/master/master.cpp Lines 7594-7597 (original), 7609-7612 (patc

Re: Review Request 65482: Fixed allocator bookkeeping of pending operations on master failover.

2018-02-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65482/#review196753 --- src/master/master.cpp Lines 7596 (patched)

Re: Review Request 65482: Fixed allocator bookkeeping of pending operations on master failover.

2018-02-02 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65482/#review196744 --- FAIL: The file 'D:\DCOS\mesos\build-output\logs\apply-review-65482

Review Request 65482: Fixed allocator bookkeeping of pending operations on master failover.

2018-02-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65482/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-8536 https:/