----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65558/#review197115 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Feb. 8, 2018, 4:37 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65558/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2018, 4:37 a.m.) > > > Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-8510 > https://issues.apache.org/jira/browse/MESOS-8510 > > > Repository: mesos > > > Description > ------- > > This patches validates that a profile's manifest must have a selector > and adds a helper function for selecting resource providers. > > > Diffs > ----- > > src/resource_provider/storage/disk_profile_utils.hpp > fa2c7ec5055577b12e5e795064bf848b9a887def > src/resource_provider/storage/disk_profile_utils.cpp > c84b6e18665086968808fb5cb0a313c1050ea587 > > > Diff: https://reviews.apache.org/r/65558/diff/3/ > > > Testing > ------- > > Tests done later in chain. > > NOTE: The next patch in chain only include necessary changes for the > validation tests. Tests for the helper function will be added in a separated > patch. > > > Thanks, > > Chun-Hung Hsiao > >