Re: Review Request 65939: Updated role endpoints for hierarchical accounting.

2018-04-09 Thread Till Toenshoff
> On April 6, 2018, 12:25 a.m., Kapil Arya wrote: > > src/master/master.hpp > > Lines 139-140 (patched) > > > > > > Now that we are keeping track of `allocatedResources` and > > `totalAllocatedResources`, we can

Re: Review Request 65939: Updated role endpoints for hierarchical accounting.

2018-04-05 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65939/#review200584 --- Hey Till, I have added some comments. Most are minor style

Re: Review Request 65939: Updated role endpoints for hierarchical accounting.

2018-04-05 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65939/ --- (Updated April 5, 2018, 4:15 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65939: Updated role endpoints for hierarchical accounting.

2018-04-05 Thread Till Toenshoff
> On March 8, 2018, 12:20 a.m., Benjamin Mahler wrote: > > src/master/http.cpp > > Lines 3491 (patched) > > > > > > Just to be sure, do we disallow double slashes? E.g. "a//b"? If so, > > then tokenize and split

Re: Review Request 65939: Updated role endpoints for hierarchical accounting.

2018-03-07 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65939/#review198755 --- Thanks Till! Can you add Meng to any hierachical role related

Review Request 65939: Updated role endpoints for hierarchical accounting.

2018-03-06 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65939/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Kapil Arya, and