Re: Review Request 66230: Added test for adding/removing framework roles.

2018-05-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/#review202533 --- Can we simplify these tests and remove the executors? Also, over

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-05-04 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/#review202499 --- Bad patch! Reviews applied: [66230, 66229, 66228, 66872] Failed

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-05-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/#review202461 --- FAIL: Failed to apply the dependent review: 66229. Failed

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-05-04 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/ --- (Updated May 4, 2018, 1:33 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-04-28 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/#review202107 --- PASS: Mesos patch 66230 was successfully built and tested.

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-04-20 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/#review201653 --- PASS: Mesos patch 66230 was successfully built and tested.

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-04-20 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/ --- (Updated April 20, 2018, 4:19 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-04-12 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/#review201080 --- PASS: Mesos patch 66230 was successfully built and tested.

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-04-12 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/ --- (Updated April 12, 2018, 9:38 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-04-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/#review200923 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-03-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/#review199816 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-03-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/#review199810 --- FAIL: Failed to apply the dependent review: 66229. Failed

Review Request 66230: Added test for adding/removing framework roles.

2018-03-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Bugs: MESOS-7258