Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.

2018-04-05 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66384/#review200570 --- Ship it! Ship It! - Andrew Schwartzmeyer On April 5, 2018,

Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.

2018-04-05 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66384/ --- (Updated April 5, 2018, 6:41 p.m.) Review request for mesos and Andrew

Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.

2018-04-03 Thread David Forsythe
> On April 2, 2018, 5:06 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/zookeeper-3.4.8.patch > > Line 154 (original), 154 (patched) > > > > > > Also, if this change should go upstream to ZooKeeper (looks to me like

Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.

2018-04-03 Thread Andrew Schwartzmeyer
> On April 2, 2018, 10:06 a.m., Andrew Schwartzmeyer wrote: > > 3rdparty/zookeeper-3.4.8.patch > > Line 154 (original), 154 (patched) > > > > > > Also, if this change should go upstream to ZooKeeper (looks to me

Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.

2018-04-02 Thread David Forsythe
> On April 2, 2018, 5:06 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/zookeeper-3.4.8.patch > > Line 154 (original), 154 (patched) > > > > > > Also, if this change should go upstream to ZooKeeper (looks to me like

Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.

2018-04-02 Thread David Forsythe
> On April 2, 2018, 5:02 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/zookeeper-3.4.8.patch > > Lines 870-873 (original), 870-872 (patched) > > > > > > This is funny, what did this get diffed against? I might have

Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.

2018-04-02 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66384/#review200292 --- 3rdparty/zookeeper-3.4.8.patch Line 154 (original), 154

Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.

2018-04-02 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66384/#review200289 --- 3rdparty/zookeeper-3.4.8.patch Line 154 (original), 154

Review Request 66384: Link libm in ZooKeeper build on FreeBSD.

2018-03-31 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66384/ --- Review request for mesos. Bugs: MESOS-4176