Re: Review Request 66423: Split `stout/os/open.hpp` into Windows and POSIX files.

2018-04-20 Thread Andrew Schwartzmeyer
> On April 18, 2018, 11:09 a.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/windows/open.hpp > > Lines 29-32 (patched) > > > > > > We won't need this note anymore (on the Windows header). That's true, but

Re: Review Request 66423: Split `stout/os/open.hpp` into Windows and POSIX files.

2018-04-18 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66423/#review200967 --- Fix it, then Ship it!

Re: Review Request 66423: Split `stout/os/open.hpp` into Windows and POSIX files.

2018-04-05 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66423/#review200576 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 5:47

Re: Review Request 66423: Split `stout/os/open.hpp` into Windows and POSIX files.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66423/#review200504 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:47

Review Request 66423: Split `stout/os/open.hpp` into Windows and POSIX files.

2018-04-03 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66423/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and