Re: Review Request 66444: Windows: Made `signals.hpp` compile.

2018-04-23 Thread Joseph Wu
> On April 4, 2018, 10:22 a.m., Andrew Schwartzmeyer wrote: > > I think our other option is to just delete this file, and have > > `os/signals.hpp` include the POSIX version, but not the (deleted) Windows > > version, with a comment that none of it is (or will be) implemented. I'm in favor of

Re: Review Request 66444: Windows: Made `signals.hpp` compile.

2018-04-05 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66444/#review200619 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 5:58 a.m.,

Re: Review Request 66444: Windows: Made `signals.hpp` compile.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66444/#review200497 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:58 a.m.

Re: Review Request 66444: Windows: Made `signals.hpp` compile.

2018-04-04 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66444/#review200467 --- I think our other option is to just delete this file, and have `os

Review Request 66444: Windows: Made `signals.hpp` compile.

2018-04-03 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66444/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and