Re: Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.

2018-04-19 Thread Greg Mann
> On April 17, 2018, 11:24 p.m., Greg Mann wrote: > > src/tests/authorization_tests.cpp > > Line 1979 (original), 1979 (patched) > > > > > > Could you also add an end-to-end test of authorization for these > > oper

Re: Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.

2018-04-19 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66532/ --- (Updated April 19, 2018, 1:01 p.m.) Review request for mesos, Chun-Hung Hsiao a

Re: Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.

2018-04-19 Thread Zhitao Li
> On April 17, 2018, 4:24 p.m., Greg Mann wrote: > > src/tests/authorization_tests.cpp > > Line 1979 (original), 1979 (patched) > > > > > > Could you also add an end-to-end test of authorization for these > > opera

Re: Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.

2018-04-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66532/#review201364 --- src/tests/authorization_tests.cpp Lines 2155 (patched)

Re: Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.

2018-04-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66532/#review201362 --- src/tests/authorization_tests.cpp Line 1979 (original), 1979 (pat

Re: Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.

2018-04-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66532/#review200943 --- PASS: Mesos patch 66532 was successfully built and tested. Review

Re: Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.

2018-04-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66532/#review200841 --- FAIL: Some of the unit tests failed. Please check the relevant log

Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.

2018-04-10 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66532/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-8748 h