Re: Review Request 66708: Refactored sending a TASK_DROPPED status update.

2018-04-19 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66708/#review201593 --- Ship it! Ship It! - Qian Zhang On April 20, 2018, 2:09 a.m.,

Re: Review Request 66708: Refactored sending a TASK_DROPPED status update.

2018-04-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66708/#review201557 --- Patch looks great! Reviews applied: [66704, 66705, 66706, 66707,

Re: Review Request 66708: Refactored sending a TASK_DROPPED status update.

2018-04-19 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66708/#review201549 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 66708: Refactored sending a TASK_DROPPED status update.

2018-04-19 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66708/ --- (Updated April 19, 2018, 6:09 p.m.) Review request for mesos, Gilbert Song, Gre

Re: Review Request 66708: Refactored sending a TASK_DROPPED status update.

2018-04-19 Thread James Peach
> On April 19, 2018, 1:58 p.m., Qian Zhang wrote: > > src/slave/slave.cpp > > Lines 2543 (patched) > > > > > > Nit: Switch the order of these two parameters since we use `message` > > before `reason` in the code be

Re: Review Request 66708: Refactored sending a TASK_DROPPED status update.

2018-04-19 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66708/#review201517 --- src/slave/slave.cpp Lines 2543 (patched)

Re: Review Request 66708: Refactored sending a TASK_DROPPED status update.

2018-04-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66708/#review201499 --- Patch looks great! Reviews applied: [66704, 66705, 66706, 66707,

Re: Review Request 66708: Refactored sending a TASK_DROPPED status update.

2018-04-18 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66708/#review201481 --- FAIL: Some of the unit tests failed. Please check the relevant log

Review Request 66708: Refactored sending a TASK_DROPPED status update.

2018-04-18 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66708/ --- Review request for mesos, Gilbert Song, Greg Mann, and Jie Yu. Bugs: MESOS-8585