Re: Review Request 66846: Added per framework metrics support for terminal task state.

2018-05-23 Thread Gilbert Song
> On May 16, 2018, 10:34 a.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 12113 (patched) > > > > > > When `task->statuses.size == 0`, I think we probably want to increment > > the terminal task state

Re: Review Request 66846: Added per framework metrics support for terminal task state.

2018-05-16 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66846/#review203253 --- src/master/master.cpp Lines 12113 (patched)

Re: Review Request 66846: Added per framework metrics support for terminal task state.

2018-05-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66846/ --- (Updated May 15, 2018, 5:45 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66846: Added per framework metrics support for terminal task state.

2018-05-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66846/ --- (Updated May 11, 2018, 1:44 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66846: Added per framework metrics support for terminal task state.

2018-05-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66846/ --- (Updated May 11, 2018, 12:44 a.m.) Review request for mesos, Benjamin Mahler,