Re: Review Request 67094: Split linux chroot into prepare and enter phases.

2018-05-16 Thread James Peach
> On May 11, 2018, 11:26 p.m., Jason Lai wrote: > > src/linux/fs.cpp > > Lines 968-1034 (original), 973-1041 (patched) > > > > > > We can also consider changing `fs::chroot::enter` with the [`pivotRoot` > >

Re: Review Request 67094: Split linux chroot into prepare and enter phases.

2018-05-11 Thread Jason Lai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67094/#review202976 --- src/linux/fs.cpp Lines 968-1034 (original), 973-1041 (patched)

Re: Review Request 67094: Split linux chroot into prepare and enter phases.

2018-05-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67094/#review202971 --- Fix it, then Ship it!

Re: Review Request 67094: Split linux chroot into prepare and enter phases.

2018-05-11 Thread Jason Lai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67094/#review202969 --- Great to see the split of `fs::enter::prepare` from

Review Request 67094: Split linux chroot into prepare and enter phases.

2018-05-11 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67094/ --- Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Zhitao Li.