Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67154/ --- (Updated May 17, 2018, 7:36 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67154/ --- (Updated May 17, 2018, 6:11 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

> On May 17, 2018, 11:12 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/include/process/grpc.hpp > > Lines 188 (patched) > > > > > > Why do we `move` here? It seems both not needed to me as `shared_ptr`'s >

Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67154/#review203317 --- Fix it, then Ship it!

Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67154/ --- (Updated May 16, 2018, 10:02 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67154/ --- (Updated May 16, 2018, 9:35 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

> On May 16, 2018, 7:45 p.m., Zhitao Li wrote: > > 3rdparty/libprocess/include/process/grpc.hpp > > Lines 125-126 (patched) > > > > > > Do we need to call out what case the `Future` itself can be failed? Currently

Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

> On May 16, 2018, 8:36 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/include/process/grpc.hpp > > Line 86 (original), 84-93 (patched) > > > > > > Is this any different than > > > >

Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67154/#review203273 --- Not a proper review, yet.

Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67154/#review203275 --- PASS: Mesos patch 67154 was successfully built and tested.

Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67154/#review203271 --- 3rdparty/libprocess/include/process/grpc.hpp Lines 122 (patched)

Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67154/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Zhitao