Re: Review Request 67212: Used `*_SOME` macro for checking `Try` values.

2018-05-29 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67212/#review203978 --- PASS: Mesos patch 67212 was successfully built and tested.

Re: Review Request 67212: Used `*_SOME` macro for checking `Try` values.

2018-05-29 Thread Benjamin Bannier
> On May 18, 2018, 8:58 p.m., Chun-Hung Hsiao wrote: > > Haven't take a good at these but they might be candidates to use the new > > macros: > > ``` > > $ grep '(EXPECT\|ASSERT)_(TRUE\|FALSE)(.*is(Some\|Error\|None)())' src -r > > src/tests/containerizer/cgroups_isolator_tests.cpp: > >

Re: Review Request 67212: Used `*_SOME` macro for checking `Try` values.

2018-05-29 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67212/ --- (Updated May 29, 2018, 10:13 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 67212: Used `*_SOME` macro for checking `Try` values.

2018-05-21 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67212/#review203503 --- Bad patch! Reviews applied: [67212, 67211, 67210] Failed

Re: Review Request 67212: Used `*_SOME` macro for checking `Try` values.

2018-05-18 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67212/#review203444 --- Ship it! Haven't take a good at these but they might be

Re: Review Request 67212: Used `*_SOME` macro for checking `Try` values.

2018-05-18 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67212/#review203408 --- PASS: Mesos patch 67212 was successfully built and tested.

Review Request 67212: Used `*_SOME` macro for checking `Try` values.

2018-05-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67212/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Repository: mesos