----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67321/#review203865 -----------------------------------------------------------
Ship it! Ship It! - Alexander Rukletsov On May 25, 2018, 11:26 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67321/ > ----------------------------------------------------------- > > (Updated May 25, 2018, 11:26 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-8954 > https://issues.apache.org/jira/browse/MESOS-8954 > > > Repository: mesos > > > Description > ------- > > The main challenge when switching from Python 2 to Python 3 is > to handle the strings, as many of them are now byte strings. I > have checked the other uses of `sys.stdout.buffer.write` while > working on this commit to check that it was the last issue of > that type in python3/post-reviews.py. > > > Diffs > ----- > > support/python3/post-reviews.py 9621898133a18c0e36e94f1d9d2bd2ea7fa512b3 > > > Diff: https://reviews.apache.org/r/67321/diff/2/ > > > Testing > ------- > > Used for posting this review: > ``` > apache-mesos (MESOS-8954) $ python3 support/python3/post-reviews.py > Running 'rbt post' across all of ... > 2ad1e4236fd851a1855f11946b51b207c719b6bc - (HEAD -> MESOS-8954) Fixed > python3/post-reviews type error. (2 minutes ago) > Creating diff of: > 2ad1e4236fd851a1855f11946b51b207c719b6bc - (HEAD -> MESOS-8954) Fixed > python3/post-reviews type error. > Press enter to continue or 'Ctrl-C' to skip. > > Review request #67321 posted. > > https://reviews.apache.org/r/67321/ > https://reviews.apache.org/r/67321/diff/ > ``` > > > Thanks, > > Armand Grillet > >
