Re: Review Request 67423: Skipped metric for non existing paths in gc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67423/ --- (Updated June 12, 2018, 1:23 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 67423: Skipped metric for non existing paths in gc.

> On June 12, 2018, 6:17 p.m., Jie Yu wrote: > > src/slave/gc.cpp > > Lines 262 (patched) > > > > > > This is a bit hacky. A better way should be modify `os::rmdir` to > > return `Try`. The second template

Re: Review Request 67423: Skipped metric for non existing paths in gc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67423/#review204623 --- Fix it, then Ship it! src/slave/gc.cpp Lines 262 (patched)

Re: Review Request 67423: Skipped metric for non existing paths in gc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67423/#review204218 --- PASS: Mesos patch 67423 was successfully built and tested.

Review Request 67423: Skipped metric for non existing paths in gc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67423/ --- Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu. Repository: