Re: Review Request 67761: Added a new registry field `minimum_capabilities`.

2019-02-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67761/#review213238 --- Ship it! I feel the patch description is a bit lacking.

Re: Review Request 67761: Added a new registry field `minimum_capabilities`.

2018-06-29 Thread Meng Zhu
> On June 29, 2018, 12:28 p.m., Joseph Wu wrote: > > src/master/registry_operations.hpp > > Lines 140-163 (patched) > > > > > > Instead of Add/Remove, how about an `UpdateMinimumCapability` operation > > instead? >

Re: Review Request 67761: Added a new registry field `minimum_capabilities`.

2018-06-29 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67761/ --- (Updated June 29, 2018, 3:48 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 67761: Added a new registry field `minimum_capabilities`.

2018-06-29 Thread Joseph Wu
> On June 29, 2018, 12:28 p.m., Joseph Wu wrote: > > src/master/registry_operations.hpp > > Lines 140-163 (patched) > > > > > > Instead of Add/Remove, how about an `UpdateMinimumCapability` operation > > instead? >

Re: Review Request 67761: Added a new registry field `minimum_capabilities`.

2018-06-29 Thread Meng Zhu
> On June 29, 2018, 12:28 p.m., Joseph Wu wrote: > > src/master/registry.proto > > Lines 88 (patched) > > > > > > Could use a comment along the lines of: > > ``` > > The minimum set of

Re: Review Request 67761: Added a new registry field `minimum_capabilities`.

2018-06-29 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67761/ --- (Updated June 29, 2018, 1:25 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 67761: Added a new registry field `minimum_capabilities`.

2018-06-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67761/#review205579 --- src/master/registry.proto Lines 88 (patched)

Review Request 67761: Added a new registry field `minimum_capabilities`.

2018-06-27 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67761/ --- Review request for mesos, Benjamin Mahler and Joseph Wu. Bugs: MESOS-8880