Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review213496 --- Ship it! I can tweak the below before committing.

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review213454 --- Patch looks great! Reviews applied: [67761, 70077, 67762]

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/ --- (Updated March 5, 2019, 10:53 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review213323 --- Patch looks great! Reviews applied: [67761, 70077, 67762]

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review213322 --- Patch looks great! Reviews applied: [67761, 70077, 67762]

Re: Review Request 67762: Added minimum capability check during master recovery.

> On Feb. 26, 2019, 6:04 p.m., Joseph Wu wrote: > > src/master/master.cpp > > Lines 1680 (patched) > > > > > > A forced recovery doesn't really make sense, if we're trying to prevent > > undefined behavior. If a

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/ --- (Updated Feb. 28, 2019, 3:08 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review213241 --- Commit description could use some extra context. Not sure if you

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review213106 --- Patch looks great! Reviews applied: [67761, 67762] Passed

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review212978 --- PASS: Mesos patch 67762 was successfully built and tested.

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/ --- (Updated Feb. 20, 2019, 10:46 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review205602 --- PASS: Mesos patch 67762 was successfully built and tested.

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review205601 --- Patch looks great! Reviews applied: [67761, 67762] Passed

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/ --- (Updated June 29, 2018, 4:37 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 67762: Added minimum capability check during master recovery.

> On June 29, 2018, 2:33 p.m., Joseph Wu wrote: > > src/master/master.cpp > > Lines 406-418 (patched) > > > > > > Consider defining a `hash` and performing > > a hashset subtraction instead of these loops. Done.

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review205583 --- src/master/master.hpp Lines 443-444 (patched)

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review205491 --- Patch looks great! Reviews applied: [67761, 67762] Passed

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review205490 --- PASS: Mesos patch 67762 was successfully built and tested.

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/ --- (Updated June 27, 2018, 10:01 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review205487 --- PASS: Mesos patch 67762 was successfully built and tested.

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review205485 --- Patch looks great! Reviews applied: [67761, 67762] Passed

Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/ --- Review request for mesos, Benjamin Mahler and Joseph Wu. Bugs: MESOS-8880