Re: Review Request 67896: Added container-specific cgroups mount for freezer & systemd subsystems.

2018-07-20 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67896/#review206298 --- Ship it! Ship It! - Gilbert Song On July 19, 2018, 2:10

Re: Review Request 67896: Added container-specific cgroups mount for freezer & systemd subsystems.

2018-07-19 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67896/ --- (Updated July 19, 2018, 5:10 p.m.) Review request for mesos and Gilbert Song.

Re: Review Request 67896: Added container-specific cgroups mount for freezer & systemd subsystems.

2018-07-19 Thread Qian Zhang
> On July 19, 2018, 6:46 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > > Lines 628 (patched) > > > > > > Should we also use `CGROUP_SEPARATOR` and move it to a common

Re: Review Request 67896: Added container-specific cgroups mount for freezer & systemd subsystems.

2018-07-18 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67896/#review206219 --- Fix it, then Ship it!

Review Request 67896: Added container-specific cgroups mount for freezer & systemd subsystems.

2018-07-12 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67896/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-9070