Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/#review207112 --- PASS: Mesos patch 68132 was successfully built and tested.

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/ --- (Updated Aug. 11, 2018, 6:09 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 68132: Batch '/state' requests on Master.

> On Aug. 9, 2018, 1:11 p.m., Benno Evers wrote: > > src/master/master.hpp > > Line 1467 (original), 1470 (patched) > > > > > > Since the `batchedStateRequests` vector acts similarly to a cache, > > maybe we

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/#review207054 --- Ship it! Looks good, thank you Alex! This will be a big win

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/#review206879 --- Fix it, then Ship it! src/master/http.cpp Lines 2874

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/#review206978 --- Patch looks great! Reviews applied: [68224, 68225, 68131, 68132]

Re: Review Request 68132: Batch '/state' requests on Master.

> On Aug. 1, 2018, 12:42 a.m., Benjamin Mahler wrote: > > A couple of comments on the benchmark information before looking at the > > code, these probably belong on the previous review, but since the numbers > > are only shown in this one I'll leave these here: > > > > * Can we compare

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/#review206942 --- PASS: Mesos patch 68132 was successfully built and tested.

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/ --- (Updated Aug. 7, 2018, 12:11 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/ --- (Updated Aug. 7, 2018, 12:10 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/ --- (Updated Aug. 7, 2018, 11:31 a.m.) Review request for mesos, Benno Evers and

Re: Review Request 68132: Batch '/state' requests on Master.

> On Aug. 1, 2018, 12:42 a.m., Benjamin Mahler wrote: > > A couple of comments on the benchmark information before looking at the > > code, these probably belong on the previous review, but since the numbers > > are only shown in this one I'll leave these here: > > > > * Can we compare

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/ --- (Updated Aug. 6, 2018, 10:30 a.m.) Review request for mesos, Benno Evers and

Re: Review Request 68132: Batch '/state' requests on Master.

> On Aug. 1, 2018, 1:59 a.m., Benjamin Mahler wrote: > > src/master/http.cpp > > Lines 2887-2889 (original), 2849-2851 (patched) > > > > > > Can you move in the request and the promise (without Owned) here? (the >

Re: Review Request 68132: Batch '/state' requests on Master.

> On Aug. 1, 2018, 1:59 a.m., Benjamin Mahler wrote: > > src/master/http.cpp > > Line 2812 (original), 2815 (patched) > > > > > > Can we keep the existing name? I believe the idea is to have them match > > the

Re: Review Request 68132: Batch '/state' requests on Master.

> On Aug. 1, 2018, 1:59 a.m., Benjamin Mahler wrote: > > Overall the approach looks good, didn't see any bugs, so just minor > > comments below. > > > > * I'm not sure where to put it but it seems we need a TODO to de-duplicate > > response processing when the principal is identical? E.g. if

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/ --- (Updated Aug. 3, 2018, 1:46 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/ --- (Updated Aug. 3, 2018, 10:49 a.m.) Review request for mesos, Benno Evers and

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/#review206768 --- Bad patch! Reviews applied: [68132, 68131] Failed command:

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/#review206714 --- Overall the approach looks good, didn't see any bugs, so just

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/#review206711 --- A couple of comments on the benchmark information before looking

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/ --- (Updated July 31, 2018, 5:24 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/ --- (Updated July 31, 2018, 5:22 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/#review206662 --- PASS: Mesos patch 68132 was successfully built and tested.

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/ --- (Updated July 31, 2018, 3:05 p.m.) Review request for mesos, Benno Evers and

Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/ --- Review request for mesos, Benno Evers and Benjamin Mahler. Bugs: MESOS-9122