Re: Review Request 68145: WIP: Sent an event to resource providers when they are removed.

2018-08-15 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68145/#review207345 --- include/mesos/resource_provider/resource_provider.proto Lines 42

Re: Review Request 68145: WIP: Sent an event to resource providers when they are removed.

2018-08-15 Thread Chun-Hung Hsiao
> On Aug. 15, 2018, 12:04 a.m., Chun-Hung Hsiao wrote: > > I'm not sure if we want to have this. If we are to follow the same pattern > > as `MARK_AGENT_GONE`, shouldn't the manager just disconnects the resource > > provider and prevents future registration? > > Benjamin Bannier wrote: >

Re: Review Request 68145: WIP: Sent an event to resource providers when they are removed.

2018-08-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68145/#review207335 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68145: WIP: Sent an event to resource providers when they are removed.

2018-08-15 Thread Benjamin Bannier
> On Aug. 15, 2018, 2:04 a.m., Chun-Hung Hsiao wrote: > > I'm not sure if we want to have this. If we are to follow the same pattern > > as `MARK_AGENT_GONE`, shouldn't the manager just disconnects the resource > > provider and prevents future registration? Removed from the MESOS-8403 chain.