Re: Review Request 68362: Made RP manager only send resource provider ID on state updates.

2018-08-20 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68362/#review207627 --- Ship it! Ship It! - Chun-Hung Hsiao On Aug. 15, 2018, 1:53 p

Re: Review Request 68362: Made RP manager only send resource provider ID on state updates.

2018-08-20 Thread Benjamin Bannier
> On Aug. 18, 2018, 12:34 a.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 7684-7690 (original) > > > > > > Where do we update the operations and total resources? The `if` statement removed here was f

Re: Review Request 68362: Made RP manager only send resource provider ID on state updates.

2018-08-17 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68362/#review207565 --- src/slave/slave.cpp Lines 7684-7690 (original)

Re: Review Request 68362: Made RP manager only send resource provider ID on state updates.

2018-08-17 Thread Benjamin Bannier
> On Aug. 16, 2018, 12:14 a.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Line 7653 (original), 7648 (patched) > > > > > > This will create a resource provider without a resource version, which > > in turn

Re: Review Request 68362: Made RP manager only send resource provider ID on state updates.

2018-08-16 Thread Chun-Hung Hsiao
> On Aug. 15, 2018, 10:14 p.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Line 7653 (original), 7648 (patched) > > > > > > This will create a resource provider without a resource version, which > > in turn

Re: Review Request 68362: Made RP manager only send resource provider ID on state updates.

2018-08-16 Thread Benjamin Bannier
> On Aug. 16, 2018, 12:14 a.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Line 7653 (original), 7648 (patched) > > > > > > This will create a resource provider without a resource version, which > > in turn

Re: Review Request 68362: Made RP manager only send resource provider ID on state updates.

2018-08-15 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68362/#review207363 --- src/slave/slave.cpp Line 7653 (original), 7648 (patched)

Review Request 68362: Made RP manager only send resource provider ID on state updates.

2018-08-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68362/ --- Review request for mesos and Chun-Hung Hsiao. Bugs: MESOS-8403 https://issu