Re: Review Request 68762: Tested container cleanup in `AgentResourceProviderConfigApiTest.Remove`.

2018-09-21 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68762/#review208886 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68762: Tested container cleanup in `AgentResourceProviderConfigApiTest.Remove`.

2018-09-21 Thread Chun-Hung Hsiao
> On Sept. 21, 2018, 10:05 a.m., Benjamin Bannier wrote: > > src/tests/agent_resource_provider_config_api_tests.cpp > > Line 35 (original), 35 (patched) > > > > > > Like you wrote in your _Testing Done_ section, this

Re: Review Request 68762: Tested container cleanup in `AgentResourceProviderConfigApiTest.Remove`.

2018-09-21 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68762/#review208754 --- Fix it, then Ship it!

Re: Review Request 68762: Tested container cleanup in `AgentResourceProviderConfigApiTest.Remove`.

2018-09-20 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68762/ --- (Updated Sept. 20, 2018, 11:15 p.m.) Review request for mesos, Benjamin

Review Request 68762: Tested container cleanup in `AgentResourceProviderConfigApiTest.Remove`.

2018-09-18 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68762/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: