Re: Review Request 69096: Moved a few allocator test helpers to `tests/allocator.hpp`.

2018-12-05 Thread Meng Zhu
> On Oct. 24, 2018, 5:22 p.m., Benjamin Mahler wrote: > > src/tests/allocator.hpp > > Lines 40-45 (patched) > > > > > > I think we some other create helpers lying around, e.g. createTask. Is > > this where these

Re: Review Request 69096: Moved a few allocator test helpers to `tests/allocator.hpp`.

2018-11-02 Thread Benjamin Mahler
> On Oct. 25, 2018, 12:22 a.m., Benjamin Mahler wrote: > > src/tests/allocator.hpp > > Lines 40-45 (patched) > > > > > > I think we some other create helpers lying around, e.g. createTask. Is > > this where these

Re: Review Request 69096: Moved a few allocator test helpers to `tests/allocator.hpp`.

2018-10-24 Thread Meng Zhu
> On Oct. 24, 2018, 5:22 p.m., Benjamin Mahler wrote: > > src/tests/allocator.hpp > > Lines 40-45 (patched) > > > > > > I think we some other create helpers lying around, e.g. createTask. Is > > this where these

Re: Review Request 69096: Moved a few allocator test helpers to `tests/allocator.hpp`.

2018-10-24 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69096/#review210010 --- Fix it, then Ship it! src/tests/allocator.hpp Lines 40-45

Review Request 69096: Moved a few allocator test helpers to `tests/allocator.hpp`.

2018-10-19 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69096/ --- Review request for mesos, Benjamin Mahler and Gastón Kleiman. Repository: