Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

2019-01-03 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69436/#review211662 --- Fix it, then Ship it! src/tests/cluster.cpp Lines 691 (patched

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

2018-12-14 Thread Armand Grillet
> On Dec. 14, 2018, 1:23 p.m., Armand Grillet wrote: > > Bad patch! > > > > Reviews applied: [69436] > > > > Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' > > BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose > > --disable-libtool-wrappers' ENVIRONMENT=

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

2018-12-14 Thread Joseph Wu
> On Dec. 14, 2018, 4:23 a.m., Armand Grillet wrote: > > Bad patch! > > > > Reviews applied: [69436] > > > > Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' > > BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose > > --disable-libtool-wrappers' ENVIRONMENT=

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

2018-12-14 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69436/#review211329 --- Bad patch! Reviews applied: [69436] Failed command: ['bash', '-c

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

2018-12-13 Thread Benno Evers
> On Nov. 23, 2018, 1:44 p.m., Andrei Budnik wrote: > > src/tests/cluster.cpp > > Lines 699 (patched) > > > > > > What if there is more than one container whose > > `Future` is ready? Should we call `settle()` for e

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

2018-11-26 Thread Joseph Wu
> On Nov. 23, 2018, 5:44 a.m., Andrei Budnik wrote: > > src/tests/cluster.cpp > > Lines 699 (patched) > > > > > > What if there is more than one container whose > > `Future` is ready? Should we call `settle()` for e

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

2018-11-26 Thread Andrei Budnik
> On Nov. 23, 2018, 1:44 p.m., Andrei Budnik wrote: > > src/tests/cluster.cpp > > Lines 699 (patched) > > > > > > What if there is more than one container whose > > `Future` is ready? Should we call `settle()` for e

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

2018-11-26 Thread Benno Evers
> On Nov. 23, 2018, 1:44 p.m., Andrei Budnik wrote: > > src/tests/cluster.cpp > > Lines 699 (patched) > > > > > > What if there is more than one container whose > > `Future` is ready? Should we call `settle()` for e

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

2018-11-23 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69436/#review210831 --- src/tests/cluster.cpp Lines 699 (patched)

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

2018-11-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69436/#review210817 --- PASS: Mesos patch 69436 was successfully built and tested. Review

Review Request 69436: Fixed flaky check in cluster::Slave destructor.

2018-11-22 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69436/ --- Review request for mesos, Andrei Budnik and Joseph Wu. Bugs: MESOS-9272 htt