Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations.

2019-03-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70063/#review213741 --- PASS: Mesos patch 70063 was successfully built and tested.

Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations.

2019-03-11 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70063/#review213601 --- src/tests/resource_quantities_tests.cpp Lines 169 (patched)

Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations.

2019-03-11 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70063/#review213602 --- Ship it! Ship It! - Benjamin Mahler On Feb. 27, 2019, 1:30

Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations.

2019-02-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70063/#review213290 --- Patch looks great! Reviews applied: [70061, 70062, 70069, 70063]

Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations.

2019-02-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70063/#review213288 --- Patch looks great! Reviews applied: [70061, 70062, 70069, 70063]

Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations.

2019-02-27 Thread Meng Zhu
> On Feb. 27, 2019, 8:34 a.m., Benjamin Mahler wrote: > > src/tests/resource_quantities_tests.cpp > > Lines 207-220 (patched) > > > > > > It feels like we could make the test quite succinct with some test > >

Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations.

2019-02-27 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70063/#review213259 --- src/tests/resource_quantities_tests.cpp Lines 207-220 (patched)

Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations.

2019-02-26 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70063/#review213247 --- Patch looks great! Reviews applied: [70061, 70062, 70063]

Re: Review Request 70063: Added test for `ResourceQuantities` arithmetic operations.

2019-02-26 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70063/#review213245 --- Patch looks great! Reviews applied: [70061, 70062, 70063]

Review Request 70063: Added test for `ResourceQuantities` arithmetic operations.

2019-02-26 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70063/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9608