Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70067/#review213582 --- Patch looks great! Reviews applied: [70123, 70171, 70067]

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

> On March 2, 2019, 7:24 a.m., Benjamin Mahler wrote: > > 3rdparty/stout/tests/option_tests.cpp > > Lines 137 (patched) > > > > > > this doesn't test that moving is working correctly? Can we test to > > ensure that

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70067/ --- (Updated March 8, 2019, 5:56 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

> On March 2, 2019, 3:24 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/tests/option_tests.cpp > > Lines 137 (patched) > > > > > > this doesn't test that moving is working correctly? Can we test to > > ensure that

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70067/#review213443 --- Ship it! Ship It! - Benjamin Bannier On March 4, 2019,

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70067/#review213432 --- Patch looks great! Reviews applied: [70123, 70067] Passed

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70067/ --- (Updated March 4, 2019, 2:50 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

> On March 4, 2019, 4:45 a.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/option.hpp > > Lines 129-130 (patched) > > > > > > Not sure this comment adds much value since it just restates what is > >

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

> On March 2, 2019, 7:24 a.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/result.hpp > > Lines 142 (patched) > > > > > > why is it left out when the others are already included? > > Benjamin Bannier

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

- Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70067/#review213266 --- On Feb. 27, 2019, 7:15 p.m., Meng Zhu wrote: > >

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

> On March 2, 2019, 4:24 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/result.hpp > > Lines 142 (patched) > > > > > > why is it left out when the others are already included? The rvalue-qualified

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

> On Feb. 27, 2019, 8:14 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/option.hpp > > Lines 127 (patched) > > > > > > I feel we should disable this one for rvalues (which should also have > > been

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70067/#review213393 --- 3rdparty/stout/include/stout/option.hpp Lines 129-130 (patched)

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70067/#review213350 --- 3rdparty/stout/include/stout/result.hpp Lines 142 (patched)

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70067/#review213311 --- Patch looks great! Reviews applied: [70067] Passed command:

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70067/#review213310 --- Patch looks great! Reviews applied: [70067] Passed command:

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70067/#review213293 --- Patch looks great! Reviews applied: [70067] Passed command:

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

> On Feb. 27, 2019, 11:14 a.m., Benjamin Bannier wrote: > > Thanks for adding these! > > > > Like Ben said, let's link this to MESOS-7124. Let's additionally create a > > ticket linked there for writing a linter to catch uses of `get` where > > `operator*` should be used (this could be

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70067/#review213268 --- Patch looks great! Reviews applied: [70067] Passed command:

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70067/#review213267 --- Patch looks great! Reviews applied: [70067] Passed command:

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70067/#review213266 --- Thanks for adding these! Like Ben said, let's link this to

Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70067/#review213265 --- Ship it! Can you link this up with

Review Request 70067: Added star operator for `Result`, `Try` and `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70067/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description