Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review214331 --- Ship it! Ship It! - Benjamin Bannier On March 28, 2019,

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

> On March 27, 2019, 12:01 p.m., James DeFelice wrote: > > src/csi/state.proto > > Line 19 (original), 19 (patched) > > > > > > are the protos in src/csi considered part of the "stable" mesos v1 API? > > if so,

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

> On March 27, 2019, 1:01 p.m., James DeFelice wrote: > > src/csi/state.proto > > Line 19 (original), 19 (patched) > > > > > > are the protos in src/csi considered part of the "stable" mesos v1 API? > > if so,

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

> On March 27, 2019, 12:01 p.m., James DeFelice wrote: > > src/csi/state.proto > > Line 19 (original), 19 (patched) > > > > > > are the protos in src/csi considered part of the "stable" mesos v1 API? > > if so,

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/ --- (Updated March 28, 2019, 7:53 a.m.) Review request for mesos, Benjamin

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

> On March 27, 2019, 12:01 p.m., James DeFelice wrote: > > src/csi/state.proto > > Line 19 (original), 19 (patched) > > > > > > are the protos in src/csi considered part of the "stable" mesos v1 API? > > if so,

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review214098 --- src/csi/state.proto Line 19 (original), 19 (patched)

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/ --- (Updated March 27, 2019, 5:54 a.m.) Review request for mesos, Benjamin

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review214030 --- PASS: Mesos patch 70248 was successfully built and tested.

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review214027 --- FAIL: Failed to apply the dependent review: 70222. Failed

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review213945 --- Patch looks great! Reviews applied: [70245, 70168, 70213, 70214,

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review213939 --- PASS: Mesos patch 70248 was successfully built and tested.

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/ --- (Updated March 22, 2019, 11:39 p.m.) Review request for mesos, Benjamin

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review213937 --- FAIL: Failed to apply the dependent review: 70222. Failed

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review213936 --- Bad review! Reviews applied: [70248, 70258, 70247, 70225, 70223,

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review213930 --- Bad review! Reviews applied: [70248, 70258, 70247, 70225, 70223,

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review213925 --- FAIL: Failed to apply the dependent review: 70222. Failed

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review213912 --- Bad review! Reviews applied: [70248, 70258, 70247, 70225, 70223,

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review213904 --- FAIL: Failed to apply the dependent review: 70222. Failed

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review213903 --- FAIL: Failed to apply the dependent review: 70217. Failed

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review213866 --- Patch looks great! Reviews applied: [70245, 70168, 70169, 70213,

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review213862 --- PASS: Mesos patch 70248 was successfully built and tested.

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/ --- (Updated March 20, 2019, 9:40 p.m.) Review request for mesos, Benjamin

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review213838 --- src/csi/utils.hpp Lines 182-183 (patched)

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review213825 --- Patch looks great! Reviews applied: [70245, 70168, 70169, 70213,

Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/#review213824 --- PASS: Mesos patch 70248 was successfully built and tested.

Review Request 70248: Adapted the unversioned `VolumeCapability`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70248/ --- Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.