Re: Review Request 70412: Made the operation feedback example framwork cleanup old reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70412/#review214526 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 70412: Made the operation feedback example framwork cleanup old reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70412/#review214523 --- Patch looks great! Reviews applied: [70411, 70412] Passed

Re: Review Request 70412: Made the operation feedback example framwork cleanup old reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70412/ --- (Updated April 9, 2019, 4:56 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 70412: Made the operation feedback example framwork cleanup old reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70412/#review214509 --- Fix it, then Ship it! LGTM, just a couple nits below.

Re: Review Request 70412: Made the operation feedback example framwork cleanup old reservations.

> On April 8, 2019, 5:02 p.m., Greg Mann wrote: > > src/examples/operation_feedback_framework.cpp > > Line 496 (original), 528 (patched) > > > > > > Should we remove this log line since we may receive operation

Re: Review Request 70412: Made the operation feedback example framwork cleanup old reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70412/ --- (Updated April 9, 2019, 4:39 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 70412: Made the operation feedback example framwork cleanup old reservations.

> On April 8, 2019, 10:26 a.m., Benno Evers wrote: > > src/examples/operation_feedback_framework.cpp > > Lines 329 (patched) > > > > > > Is this always true even in the presence of `RESERVATION_REFINEMENT`? > >

Re: Review Request 70412: Made the operation feedback example framwork cleanup old reservations.

> On April 8, 2019, 5:26 p.m., Benno Evers wrote: > > src/examples/operation_feedback_framework.cpp > > Lines 329 (patched) > > > > > > Is this always true even in the presence of `RESERVATION_REFINEMENT`? > >

Re: Review Request 70412: Made the operation feedback example framwork cleanup old reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70412/#review214481 --- src/examples/operation_feedback_framework.cpp Lines 192

Re: Review Request 70412: Made the operation feedback example framwork cleanup old reservations.

> On April 8, 2019, 5:26 p.m., Benno Evers wrote: > > src/examples/operation_feedback_framework.cpp > > Lines 329 (patched) > > > > > > Is this always true even in the presence of `RESERVATION_REFINEMENT`? > >

Re: Review Request 70412: Made the operation feedback example framwork cleanup old reservations.

> On April 8, 2019, 10:26 a.m., Benno Evers wrote: > > src/examples/operation_feedback_framework.cpp > > Lines 329 (patched) > > > > > > Is this always true even in the presence of `RESERVATION_REFINEMENT`? This

Re: Review Request 70412: Made the operation feedback example framwork cleanup old reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70412/#review214468 --- Fix it, then Ship it!

Re: Review Request 70412: Made the operation feedback example framwork cleanup old reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70412/#review214438 --- Patch looks great! Reviews applied: [70411, 70412] Passed

Re: Review Request 70412: Made the operation feedback example framwork cleanup old reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70412/#review214437 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 70412: Made the operation feedback example framwork cleanup old reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70412/ --- Review request for mesos, Benno Evers and Greg Mann. Repository: mesos