Re: Review Request 70579: Added a Task Scheduler to simplify testing.

2019-05-10 Thread Chun-Hung Hsiao
> On May 10, 2019, 3:31 a.m., Chun-Hung Hsiao wrote: > > src/tests/utils/task_scheduler.cpp > > Lines 289 (patched) > > > > > > ``` > > offers_.erase(std::remove_if(...), offers_.end()); > > ``` > >

Re: Review Request 70579: Added a Task Scheduler to simplify testing.

2019-05-10 Thread Benjamin Mahler
> On May 10, 2019, 3:31 a.m., Chun-Hung Hsiao wrote: > > src/scheduler/scheduler.cpp > > Lines 1010 (patched) > > > > > > Instead of introducing this, we could change the `TestMesos` template > > in

Re: Review Request 70579: Added a Task Scheduler to simplify testing.

2019-05-09 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70579/#review215174 --- Thanks for your work on this test scheduler!

Review Request 70579: Added a Task Scheduler to simplify testing.

2019-05-01 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70579/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-8511