Re: Review Request 70581: Add flag ignoring docker manifest config metadata.

2019-05-14 Thread Jacob Janco
> On May 14, 2019, 7:20 a.m., James Peach wrote: > > You dropeed the change to > > `src/slave/containerizer/mesos/provisioner/store.cpp`, but AFAICT, you > > still need it. > > > > Please update the relevant `docker/runtime` documentation in ` > > docs/isolators/docker-runtime.md` and

Re: Review Request 70581: Add flag ignoring docker manifest config metadata.

2019-05-14 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70581/#review215239 --- You dropeed the change to

Re: Review Request 70581: Add flag ignoring docker manifest config metadata.

2019-05-13 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70581/#review215237 --- Patch looks great! Reviews applied: [70581] Passed command:

Re: Review Request 70581: Add flag ignoring docker manifest config metadata.

2019-05-13 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70581/ --- (Updated May 14, 2019, 3:13 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 70581: Add flag ignoring docker manifest config metadata.

2019-05-10 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70581/#review215182 --- Patch looks great! Reviews applied: [70581] Passed command:

Re: Review Request 70581: Add flag ignoring docker manifest config metadata.

2019-05-09 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70581/#review215172 --- docs/configuration/agent.md Lines 648 (patched)

Re: Review Request 70581: Add flag ignoring docker manifest config metadata.

2019-05-09 Thread Jacob Janco
> On May 2, 2019, 10:16 p.m., James Peach wrote: > > The new flag should also be documented in the > > [upgrade](https://github.com/apache/mesos/blob/master/docs/upgrades.md) > > doc. You'll need to add a new 1.9.x section. Done. - Jacob

Re: Review Request 70581: Add flag ignoring docker manifest config metadata.

2019-05-09 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70581/ --- (Updated May 9, 2019, 7 p.m.) Review request for mesos, Gilbert Song and James

Re: Review Request 70581: Add flag ignoring docker manifest config metadata.

2019-05-02 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70581/#review215004 --- The new flag should also be documented in the

Review Request 70581: Add flag ignoring docker manifest config metadata.

2019-05-02 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70581/ --- Review request for mesos, Gilbert Song and James Peach. Bugs: MESOS-9760