Re: Review Request 70620: Made SLRP allow changes in volume context.

2019-05-21 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70620/ --- (Updated May 22, 2019, 2:58 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 70620: Made SLRP allow changes in volume context.

2019-05-21 Thread Benjamin Bannier
> On May 14, 2019, 12:04 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Line 923 (original), 930 (patched) > > > > > > Let's create a dedicated error message. > > Chun-Hung Hsiao

Re: Review Request 70620: Made SLRP allow changes in volume context.

2019-05-20 Thread Chun-Hung Hsiao
> On May 14, 2019, 10:04 a.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Line 923 (original), 930 (patched) > > > > > > Let's create a dedicated error message. Do you mean printing

Re: Review Request 70620: Made SLRP allow changes in volume context.

2019-05-20 Thread Chun-Hung Hsiao
> On May 12, 2019, 12:44 a.m., James DeFelice wrote: > > src/resource_provider/storage/provider.cpp > > Lines 1078 (patched) > > > > > > how often are these conversions applied? i suppose it's every time that > >

Re: Review Request 70620: Made SLRP allow changes in volume context.

2019-05-14 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70620/#review215220 --- Fix it, then Ship it!

Re: Review Request 70620: Made SLRP allow changes in volume context.

2019-05-11 Thread James DeFelice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70620/#review215202 --- src/resource_provider/storage/provider.cpp Lines 1078 (patched)

Review Request 70620: Made SLRP allow changes in volume context.

2019-05-09 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70620/ --- Review request for mesos, Benjamin Bannier and James DeFelice. Bugs: