Re: Review Request 70891: Wrapped launcher in `LauncherTracker`.

2019-07-17 Thread Andrei Budnik
> On Июль 17, 2019, 7:08 д.п., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 350 (patched) > > > > > > isn't this always true? `futureTracker` can be a `nullptr` in tests. -

Re: Review Request 70891: Wrapped launcher in `LauncherTracker`.

2019-07-17 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70891/#review216683 --- Fix it, then Ship it!

Re: Review Request 70891: Wrapped launcher in `LauncherTracker`.

2019-07-12 Thread Andrei Budnik
> On Июль 1, 2019, 7:15 д.п., Qian Zhang wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 347-349 (patched) > > > > > > Can we merge these into a single line? Updated this code a bit. Not sure

Re: Review Request 70891: Wrapped launcher in `LauncherTracker`.

2019-07-01 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70891/#review216262 --- src/slave/containerizer/mesos/containerizer.cpp Lines 347-349

Review Request 70891: Wrapped launcher in `LauncherTracker`.

2019-06-19 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70891/ --- Review request for mesos, Gilbert Song and Qian Zhang. Bugs: MESOS-9841